xfs
[Top] [All Lists]

Re: [PATCH] remove superflous xfs_readsb call in xfs_mountfs

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] remove superflous xfs_readsb call in xfs_mountfs
From: Donald Douwsma <donaldd@xxxxxxx>
Date: Mon, 03 Mar 2008 11:32:00 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080222034845.GA5354@lst.de>
References: <20071218174829.GA3195@lst.de> <20080222034845.GA5354@lst.de>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.6 (X11/20071022)
Christoph Hellwig wrote:
> On Tue, Dec 18, 2007 at 06:48:29PM +0100, Christoph Hellwig wrote:
>> When xfs_mountfs is called by xfs_mount xfs_readsb was called 35 lines
>> above unconditionally, so there is no need to try to read the superblock
>> if it's not present.  If any other port doesn't have the superblock
>> read at this point it should just call it directly from it's xfs_mount
>> equivalent.
> 
> Ping?
Looks good, will be in shortly.

Don

> 
>>
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>>
>> Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c    2007-12-17 14:34:57.000000000 
>> +0100
>> +++ linux-2.6-xfs/fs/xfs/xfs_mount.c 2007-12-17 14:35:17.000000000 +0100
>> @@ -968,11 +968,6 @@ xfs_mountfs(
>>      int             uuid_mounted = 0;
>>      int             error = 0;
>>  
>> -    if (mp->m_sb_bp == NULL) {
>> -            error = xfs_readsb(mp, mfsi_flags);
>> -            if (error)
>> -                    return error;
>> -    }
>>      xfs_mount_common(mp, sbp);
>>  
>>      /*
> ---end quoted text---
> 


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] remove superflous xfs_readsb call in xfs_mountfs, Donald Douwsma <=