xfs
[Top] [All Lists]

[REVIEW #3] fix mkfs.xfs agcount between 16 and 128MB

To: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Subject: [REVIEW #3] fix mkfs.xfs agcount between 16 and 128MB
From: "Barry Naujok" <bnaujok@xxxxxxx>
Date: Mon, 25 Feb 2008 18:11:07 +1100
In-reply-to: <op.t62i75mp3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Organization: SGI
References: <op.t61916fp3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <op.t62i75mp3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Opera Mail/9.24 (Win32)
On Mon, 25 Feb 2008 18:03:31 +1100, Barry Naujok <bnaujok@xxxxxxx> wrote:

On Mon, 25 Feb 2008 14:45:32 +1100, Barry Naujok <bnaujok@xxxxxxx> wrote:

With the AG count = 4 changes for a single disk, device sizes between
64MB
and 128MB still scale from 4 to 8 AGs. This is causing some questions!

The attached patch enforces 4 AGs for devices between 64 and 128MB
(including multi-disk setups, which should be extremely rare at this
size). This means the AG size will vary from 16 to 32MB depending on the
device size.

Barry.

With more questioning and playing, it seems < 64MB wasn't exactly optimal
either. Basically, the size was always rounded to a multiple of 16MB
(which is the minimum AG size).

The new patch basically enforces agcount=2 for 32 to 64MB and agcount=1
for less than 32MB.

Ok, one more change (the last I hope!!)

With the last patch, the "count" variable becomes redundant. This patch
(which supercedes the last two patches) eliminates the count variable.

Attachment: fix_agcount_in_mkfs_for_small_sizes.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>