Re: [patch] fix inode leak in xfs_iget

xfs

Re: [patch] fix inode leak in xfs_iget_core()

To:	David Chinner <dgc@xxxxxxx>
Subject:	Re: [patch] fix inode leak in xfs_iget_core()
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sat, 23 Feb 2008 04:22:55 -0500
Cc:	xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<20080223061924.GI155259@xxxxxxx>
References:	<20080223061924.GI155259@xxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.17 (2007-11-01)

On Sat, Feb 23, 2008 at 05:19:24PM +1100, David Chinner wrote:
> If the radix_tree_preload() fails, we need to destroy the
> inode we just read in before trying again. This could leak
> xfs_vnode structures when there is memory pressure. Noticed
> by Christoph Hellwig.

What we're leaking would be the xfs_inode.  But this is exactly
the patch I had so OK from me :)

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch] fix inode leak in xfs_iget_core(), David Chinner Re: [patch] fix inode leak in xfs_iget_core(), Christoph Hellwig <=

Previous by Date:	[patch] fix inode leak in xfs_iget_core(), David Chinner
Next by Date:	Re: Marking inode dirty latency > 1000 msec on XFS!, Török Edwin
Previous by Thread:	[patch] fix inode leak in xfs_iget_core(), David Chinner
Next by Thread:	xfs I/O error, Rekrutacja119
Indexes:	[Date] [Thread] [Top] [All Lists]