xfs
[Top] [All Lists]

Re: [RFC, patch 1/2] Allow up to 1GB logs in mkfs.xfs

To: Niv Sardi <xaiki@xxxxxxxxxxxxx>
Subject: Re: [RFC, patch 1/2] Allow up to 1GB logs in mkfs.xfs
From: David Chinner <dgc@xxxxxxx>
Date: Fri, 22 Feb 2008 16:03:01 +1100
Cc: David Chinner <dgc@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <ncctzk11zhl.fsf@xxxxxxx>
References: <20080221230833.GG155407@xxxxxxx> <ncctzk11zhl.fsf@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Fri, Feb 22, 2008 at 01:44:38PM +1100, Niv Sardi wrote:
> David Chinner <dgc@xxxxxxx> writes:
> > Increase the maximum log size supported by mkfs.
....
> > Hence logs larger than 2^30 will not work without kernel
> > modifications.  Therefore this change is limited to increasing the
> > log size to what we can currently support in kernel space with
> > needing kernel modifications.
> 
> I'm glad you got time to get around this, I didn't include it in the
> first batch as I was told it 'broke things'.

Right. There's all sorts of nasties lurking if we go over 1GB in
size, but AFAICT up to 1GB is OK. There's still lots of validation
needing to be done - that's why this is an "RFC" and not something
ready for checkin yet. That's where more eye's and testers are
handy...

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>