Re: [REVIEW] Fix end of device zeroing with > 1K sector sizes

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Barry Naujok wrote:
> It has been found that mkfs with big sector sizes and devices/partitions
> that aren't aligned to the sector size can cause short writes when zeroing
> the end of the device. As mkfs.xfs didn't complete, the filesystem is
> unmountable.
> 
> Eg:
> 
> # mkfs.xfs -f -L fs_1 -s size=4096 -l size=64m,sunit=512 /dev/hdd1
> mkfs.xfs: error - wrote only 130048 of 131072 bytes
> 
> 
> The attached patch rounds down the device size to either 1K or
> the sector size, whichever is greater.

Hopefully to a multiple thereof ;)

Looks good to me... and strangely familiar!

-Eric

> Barry.
>