Re: [patch, debug, 1/2] use atomic counters for ktrace buffer indexes

xfs

Re: [patch, debug, 1/2] use atomic counters for ktrace buffer indexes

To:	David Chinner <dgc@xxxxxxx>
Subject:	Re: [patch, debug, 1/2] use atomic counters for ktrace buffer indexes
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 21 Feb 2008 23:05:45 -0500
Cc:	xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<20080218230010.GT155407@xxxxxxx>
References:	<20080218230010.GT155407@xxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.17 (2007-11-01)

On Tue, Feb 19, 2008 at 10:00:10AM +1100, David Chinner wrote:
> ktrace_enter() is consuming vast amounts of CPU time
> due to the use of a single global lock for protecting
> buffer index increments. Change it to use per-buffer
> atomic counters - this reduces ktrace_enter() overhead
> during a trace intensive test on a 4p machine from 58%
> of all CPU time to 12% and halves test runtime.

This one is fine.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch, debug, 1/2] use atomic counters for ktrace buffer indexes, David Chinner Re: [patch, debug, 1/2] use atomic counters for ktrace buffer indexes, Christoph Hellwig <=

Previous by Date:	[PATCH 5/8] cleanup vnode use in xfs_lookup, Christoph Hellwig
Next by Date:	Re: [patch, debug, 2/2] Use power-of-2 size ktrace buffers, Christoph Hellwig
Previous by Thread:	[patch, debug, 1/2] use atomic counters for ktrace buffer indexes, David Chinner
Next by Thread:	[patch, debug, 2/2] Use power-of-2 size ktrace buffers, David Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]