Re: [patch] Don't change ctime in truncate is size does not change

xfs

Re: [patch] Don't change ctime in truncate is size does not change

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [patch] Don't change ctime in truncate is size does not change
From:	David Chinner <dgc@xxxxxxx>
Date:	Fri, 22 Feb 2008 09:50:13 +1100
Cc:	David Chinner <dgc@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<20080220232615.GA25493@xxxxxxxxxxxxx>
References:	<20080218233251.GV155407@xxxxxxx> <20080220232615.GA25493@xxxxxxxxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.4.2.1i

On Wed, Feb 20, 2008 at 06:26:15PM -0500, Christoph Hellwig wrote:
> > +           if (vap->va_size != ip->i_size || mask & XFS_AT_CTIME)
> 
> Normal Linux style is to always have braces around the 'foo & bar'
> statements to avoid operator precedance problems when re-ordering the
> statements.  Otherwise this one looks good.

Fixed up. Thank's for the review.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch] Don't change ctime in truncate is size does not change, David Chinner Re: [patch] Don't change ctime in truncate is size does not change, Mark Goodwin Re: [patch] Don't change ctime in truncate is size does not change, David Chinner Re: [patch] Don't change ctime in truncate is size does not change, Christoph Hellwig Re: [patch] Don't change ctime in truncate is size does not change, David Chinner <=

Previous by Date:	Re: [patch] detect and correct bad features2 superblock field, David Chinner
Next by Date:	[RFC, patch 1/2] Allow up to 1GB logs in mkfs.xfs, David Chinner
Previous by Thread:	Re: [patch] Don't change ctime in truncate is size does not change, Christoph Hellwig
Next by Thread:	Re: xfs: convert beX_add to beX_add_cpu patch(2.6.25-rc2), Timothy Shimmin
Indexes:	[Date] [Thread] [Top] [All Lists]