Re: [patch] Don't change ctime in truncate is size does not change

xfs

Re: [patch] Don't change ctime in truncate is size does not change

To:	David Chinner <dgc@xxxxxxx>
Subject:	Re: [patch] Don't change ctime in truncate is size does not change
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 20 Feb 2008 18:26:15 -0500
Cc:	xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<20080218233251.GV155407@xxxxxxx>
References:	<20080218233251.GV155407@xxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.17 (2007-11-01)

> +             if (vap->va_size != ip->i_size || mask & XFS_AT_CTIME)

Normal Linux style is to always have braces around the 'foo & bar'
statements to avoid operator precedance problems when re-ordering the
statements.  Otherwise this one looks good.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch] Don't change ctime in truncate is size does not change, David Chinner Re: [patch] Don't change ctime in truncate is size does not change, Mark Goodwin Re: [patch] Don't change ctime in truncate is size does not change, David Chinner Re: [patch] Don't change ctime in truncate is size does not change, Christoph Hellwig <= Re: [patch] Don't change ctime in truncate is size does not change, David Chinner

Previous by Date:	Re: Is CVS stable?, David Chinner
Next by Date:	Re: [PATCH] fix mount option pasing to make inode cluster deletion default (again), Josef 'Jeff' Sipek
Previous by Thread:	Re: [patch] Don't change ctime in truncate is size does not change, David Chinner
Next by Thread:	Re: [patch] Don't change ctime in truncate is size does not change, David Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]