Re: [patch] detect and correct bad features2 superblock field

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Feb 20, 2008 at 04:40:41PM +1100, David Chinner wrote:
> There is a bug in mkfs.xfs that can result in writing the features2
> field in the superblock to the wrong location. This only occurs
> on some architectures, typically those with 32 bit userspace and
> 64 bit kernels.

Well, we don't use different ABIs for kernel vs userspace so some
kernels will get it wrong aswell, you just won't notice until moving
to a different box because userspace is the same.

> +
> +     /* must be padded to 64 bit alignment */
>  } xfs_dsb_t;

I'm pretty sure there is some gcc __packed__ magic to enfore that,
might it be worth to poke some gcc experts to add it?


But the actual patch looks fine, ACK from me.