Re: [PATCH 1/1] XFS: replace *_IDELETE with *_IKEEP

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Christoph Hellwig wrote:
> On Thu, Feb 14, 2008 at 02:45:39AM -0500, Josef 'Jeff' Sipek wrote:
>> Change the *_IDELETE flags to *_IKEEP, and flip the logic as necessary.
>>
>> This completely eliminates the no-no-no-idelete madness.
>>
>> Additionally, "ikeep" or "noikeep" is always displayed in /proc/mounts
>> option string. This should help clear up any confusion about what the
>> current mode is.
> 
> Looks fine to me, and I think the changed display in /proc/<pid>/mounts
> is fine aswell.
> 

IMHO if we want to display defaults, then we should probably change it
so that all defaults are displayed, and not make noikeep special in this
respect.  (oh, and "noquota" is already there, too)

Doesn't matter much to me either way but it should be consistent across
all options, I think.

-Eric