xfs
[Top] [All Lists]

Re: [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct lis

To: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct list_head
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 4 Feb 2008 15:52:30 -0500
Cc: dgc@xxxxxxx, xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
In-reply-to: <1202106488-31494-1-git-send-email-jeffpc@xxxxxxxxxxxxxx>
References: <20080125070800.GH155407@xxxxxxx> <1202106488-31494-1-git-send-email-jeffpc@xxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Mon, Feb 04, 2008 at 01:28:08AM -0500, Josef 'Jeff' Sipek wrote:
> Signed-off-by: Josef 'Jeff' Sipek <jeffpc@xxxxxxxxxxxxxx>
> ---
> This patch assumes you already have Dave Chinner's patch for
> xfsidbg_xlogitem and xfsidbg_xaildump is needed.
> 
> Changes since V1:
> 
> - Pass around a pointer to the AIL, not the struct list_head
> - Make sure things compile & run with CONFIG_XFS_DEBUG

Does it work with XFS_TRANS_DEBUG defined aswell?

> -     lip = xfs_ail_min(&(mp->m_ail.xa_ail));
> +     lip = xfs_ail_min(&(mp->m_ail));

Care to remove these useless braces in all the places you touch while you're at 
it?


<Prev in Thread] Current Thread [Next in Thread>