xfs
[Top] [All Lists]

Re: [PATCH, mainline-only] remove dmapi cruft in xfs_file.c

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH, mainline-only] remove dmapi cruft in xfs_file.c
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 29 Feb 2008 00:30:48 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <47C73849.3090406@sandeen.net>
References: <20080208044405.GB15013@lst.de> <47C73849.3090406@sandeen.net>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Thu, Feb 28, 2008 at 04:40:09PM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > The dmapi cruft in xfs_file.c is totally out of date in mainline vs
> > CVS, and at this point just removing this code which can't be used on
> > mainline at all seems to be the best option to keep it maintainable.
> 
> When doing this should probably whack the:
> 
> #ifdef HAVE_FOP_OPEN_EXEC
>         .open_exec      = xfs_file_open_exec,
> #endif
> 
> from xfs_file_operations, too?

Yes,  but no urgeny for now as we've missed the .25 window anyway.


<Prev in Thread] Current Thread [Next in Thread>