xfs
[Top] [All Lists]

Re: [patch, debug, 2/2] Use power-of-2 size ktrace buffers

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [patch, debug, 2/2] Use power-of-2 size ktrace buffers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 22 Feb 2008 19:17:15 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20080222043020.GN155407@sgi.com>
References: <20080218230112.GU155407@sgi.com> <20080222040806.GB16993@infradead.org> <20080222043020.GN155407@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Fri, Feb 22, 2008 at 03:30:20PM +1100, David Chinner wrote:
> Ok, I'll cook up another patch for that and send it out.

Yeah, making that a separate patch is fine with me.  It's just a logical
next step.

> > a second step ktrace should be replaced with something based on the
> > various trace thingies floating around allowing to read out the trace
> > buffer from userspace instead of having to rely on kdb.
> 
> Yeah, that make sense for tracing from userspace. But most of the
> time I find a need for the tracing is when the machine has crashed
> or assert failed. Hence I don't see that we can really remove the
> kdb side of things. Perhaps two different tracing modules could
> be done.....

It should still be one tracing buffer, with both a userspace space
interface and one from the various kernel debuggers.  Adding the
trace buffers to core dumps in addition would be even better.


<Prev in Thread] Current Thread [Next in Thread>