* Christoph Hellwig <hch@xxxxxxxxxxxxx> [2008-02-10 00:04:46 -0500]:
> On Sat, Feb 09, 2008 at 01:42:42PM -0600, Eric Sandeen wrote:
> > (if this one is too purely cosmetic I won't be offended)
> >
> > The forward declarations for the xfs_ioctl() helpers and
> > the associated comment about gcc behavior really aren't
> > needed; all of these functions are marked STATIC which
> > includes noinline, and the stack usage won't be a problem.
> >
> > This effectively just removes the forward declarations and
> > moves xfs_ioctl() back to the end of the file.
>
> Fine in generaly, but I'm a bit worried about the too cosmetic one.
> If the gods at sgi decide it's worth it please get it in ASAP (and
> that includes 2.6.25).
>
> >
> > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> >
> > ---
> >
> > xfs_ioctl.c | 563 ++++++++++++++++----------------------
> > 1 files changed, 255 insertions(+), 308 deletions(-)
Less code same features, can only be good, I'll push it to -dev
Cheers,
--
Niv
|