Re: [PATCH, Updated] remove shouting-indirection macros from xfs_sb.h

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Eric Sandeen wrote:
> (missed one instance of XFS_SB_VERSION_HASLOGV2)
> 
> Remove macro-to-small-function indirection from xfs_sb.h,
> and remove some which are completely unused.
> 
> Some day I'll get them all...

Christoph likes it.  does sgi?

Thanks,
-Eric

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> 
> ---
> 
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ioctl.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_ioctl.c
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ioctl.c
> @@ -1052,7 +1052,7 @@ xfs_ioctl(
>                * Only allow the sys admin to reserve space unless
>                * unwritten extents are enabled.
>                */
> -             if (!XFS_SB_VERSION_HASEXTFLGBIT(&mp->m_sb) &&
> +             if (!xfs_sb_version_hasextflgbit(&mp->m_sb) &&
>                   !capable(CAP_SYS_ADMIN))
>                       return -EPERM;
>