xfs
[Top] [All Lists]

Re: Differences in mkfs.xfs and xfs_info output.

To: Jan Derfinak <ja@xxxxxxxxxxxx>
Subject: Re: Differences in mkfs.xfs and xfs_info output.
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 15 Feb 2008 22:33:32 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <47B66223.4080604@sandeen.net>
References: <Pine.LNX.4.63.0802160149590.4592@alienAngel.home.sk> <47B66223.4080604@sandeen.net>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.9 (Macintosh/20071031)
Eric Sandeen wrote:

> Jan Derfinak wrote:
>   
>> features2 = 0
>>     
>
>
> Looks like neither XFS_SB_VERSION2_ATTR2BIT nor
> XFS_SB_VERSION2_LAZYSBCOUNTBIT is in fact set.
>
> You're on x86_64 aren't you...
>
> This reminds me of an email I sent in 2006....
>   
Does this make it happier for you?  Hmm actually the kernel needs
the analogous change too.  And then probably something to fix up 
all the misformatted filesystems out there.... yuck.

Hmm and I don't know how lazy-sb-count is getting lost, yet :)

Index: xfsprogs/include/xfs_sb.h
===================================================================
--- xfsprogs.orig/include/xfs_sb.h
+++ xfsprogs/include/xfs_sb.h
@@ -151,6 +151,7 @@ typedef struct xfs_sb
        __uint16_t      sb_logsectsize; /* sector size for the log, bytes */
        __uint32_t      sb_logsunit;    /* stripe unit size for the log */
        __uint32_t      sb_features2;   /* additional feature bits */
+       __uint32_t      sb_dummy;       /* explicit padding */
 } xfs_sb_t;
 
 /*
@@ -169,7 +170,7 @@ typedef enum {
        XFS_SBS_GQUOTINO, XFS_SBS_QFLAGS, XFS_SBS_FLAGS, XFS_SBS_SHARED_VN,
        XFS_SBS_INOALIGNMT, XFS_SBS_UNIT, XFS_SBS_WIDTH, XFS_SBS_DIRBLKLOG,
        XFS_SBS_LOGSECTLOG, XFS_SBS_LOGSECTSIZE, XFS_SBS_LOGSUNIT,
-       XFS_SBS_FEATURES2,
+       XFS_SBS_FEATURES2, XFS_SBS_DUMMY,
        XFS_SBS_FIELDCOUNT
 } xfs_sb_field_t;
 
Index: xfsprogs/libxfs/xfs_mount.c
===================================================================
--- xfsprogs.orig/libxfs/xfs_mount.c
+++ xfsprogs/libxfs/xfs_mount.c
@@ -140,6 +140,7 @@ static struct {
     { offsetof(xfs_sb_t, sb_logsectsize),0 },
     { offsetof(xfs_sb_t, sb_logsunit),  0 },
     { offsetof(xfs_sb_t, sb_features2),         0 },
+    { offsetof(xfs_sb_t, sb_dummy),     0 },
     { sizeof(xfs_sb_t),                         0 }
 };
 



<Prev in Thread] Current Thread [Next in Thread>