Re: [patch] Prevent AIL lock contention during transaction completion

[Timothy Shimmin <tes@xxxxxxx>]

David Chinner wrote:
> On Fri, Jan 25, 2008 at 06:42:35PM +1100, David Chinner wrote:
> > On Fri, Jan 25, 2008 at 05:51:33PM +1100, Timothy Shimmin wrote:
> > > So do we really need to call xlog_assign_tail_lsn() then?
> > > Or are we just being conservative in case we missed something?
> > Conservative - the last thing I want is to introduce a subtle
> > difference to the tail lsn in the log record because we didn't
> > update it immediately before writing it to disk. I think we are
> > probably safe removing it, but lets leave that until we got some
> > wider test coverage on this change first....
>
> Tim - did you finish the review of this? Testing on the 2048p
> machine appears to have been successful, so I'm just waiting
> on review ACKs now....
>
> Cheers,
>
> Dave.

Yep, that was an ACK.

--Tim