Re: [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct list_head

["Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>]

On Fri, Jan 25, 2008 at 06:08:00PM +1100, David Chinner wrote:
...
> Few things that really should be done in this first patch. Rather
> than passing listheads to the xfs_ail_*() functions, it should
> really be changed to pass the xfs_ail_t to those functions. The
> structure of the list should be opaque to everything outside these
> functions.
 
Agreed. I'm going to send a fixed up version of the patch sometime tomorrow.

> It also needs to build with XFS_DEBUG enabled - that means
> xfs_ail_check needs updating, but I've already got a patch
> for the other bit (xfsidbg.c) that works which is attached below.

Lesson learned...compile with XFS_DEBUG on.

Josef 'Jeff' Sipek.

-- 
Real Programmers consider "what you see is what you get" to be just as bad a
concept in Text Editors as it is in women. No, the Real Programmer wants a
"you asked for it, you got it" text editor -- complicated, cryptic,
powerful, unforgiving, dangerous.