| To: | xfs-oss <xfs@xxxxxxxxxxx>, Niv Sardi <xaiki@xxxxxxx> |
|---|---|
| Subject: | small problem w/ new xfs defaults patch |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Sun, 20 Jan 2008 21:46:39 -0600 |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.9 (Macintosh/20071031) |
Index: xfsprogs-2.9.4/growfs/xfs_growfs.c
===================================================================
--- xfsprogs-2.9.4.orig/growfs/xfs_growfs.c
+++ xfsprogs-2.9.4/growfs/xfs_growfs.c
@@ -58,7 +58,6 @@ report_info(
int isint,
char *logname,
char *rtname,
- int unwritten,
int lazycount,
int dirversion,
int logversion,
@@ -68,7 +67,7 @@ report_info(
"meta-data=%-22s isize=%-6u agcount=%u, agsize=%u blks\n"
" =%-22s sectsz=%-5u attr=%u\n"
"data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n"
- " =%-22s sunit=%-6u swidth=%u blks, unwritten=%u\n"
+ " =%-22s sunit=%-6u swidth=%u blks"
"naming =version %-14u bsize=%-6u\n"
"log =%-22s bsize=%-6u blocks=%u, version=%u\n"
" =%-22s sectsz=%-5u sunit=%u blks, lazy-count=%u\n"
couple things... you lost a "\n" off the end of the data section there...
Also, do you really want to drop reporting of unwritten extents? Even
if you're disallowing the selection on new mkfs's there may still be
different flavors of filesystems in existence, should it still be reported?
-Eric
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.24-rc8: possible circular locking dependency detected, David Chinner |
|---|---|
| Next by Date: | Re: [REVIEW 1/2] Case insensitive support for XFS - kernel patch, Barry Naujok |
| Previous by Thread: | [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct list_head, Josef 'Jeff' Sipek |
| Next by Thread: | Re: small problem w/ new xfs defaults patch, Niv Sardi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |