[Top] [All Lists]

Re: [REVIEW] Refactor xfs_repair's process_dinode_int

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [REVIEW] Refactor xfs_repair's process_dinode_int
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 16 Jan 2008 06:32:35 +0000
Cc: Timothy Shimmin <tes@xxxxxxx>, Barry Naujok <bnaujok@xxxxxxx>, Chandan Talukdar <chandan@xxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <20080116045943.GU155407@xxxxxxx>
References: <4782B72D.8070208@xxxxxxxxx> <47833C0F.6070206@xxxxxxxxx> <op.t4m0r1an3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <478D1899.9080201@xxxxxxxxx> <op.t4zzbvbs3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <478D75C2.5010004@xxxxxxx> <20080116045943.GU155407@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Jan 16, 2008 at 03:59:43PM +1100, David Chinner wrote:
> As a result the kernel does not have endian types for single
> byte variables (ie. there's __be16, __be32, __be64 but not __be8),
> nor are there cpu_to_be8 or be8_to_cpu conversion functions.
> Hence the lack of them in the XFS code ;)
> > I guess you might consider that you are letting people know
> > that we need to endian convert this value in general and
> > that if we change the code in the future it might be needed...
> Well, that should be obvious when changing the structure
> that has lots of __beX types in already....

Actually enabling sparse checking for endianess annotations is still on
my todo list.  I started this project a while ago but failed when the
cgcc wrapper had some problems interacting with libtool.  I'll see how
to get that resolved.

<Prev in Thread] Current Thread [Next in Thread>