| To: | Timothy Shimmin <tes@xxxxxxx> |
|---|---|
| Subject: | Re: [patch] Prevent AIL lock contention during transaction completion |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Fri, 25 Jan 2008 18:42:35 +1100 |
| Cc: | David Chinner <dgc@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <479986F5.7070800@sgi.com> |
| References: | <20080121052330.GG155259@sgi.com> <4796E8C8.3030702@sgi.com> <20080123073446.GU155259@sgi.com> <479986F5.7070800@sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Fri, Jan 25, 2008 at 05:51:33PM +1100, Timothy Shimmin wrote: > So do we really need to call xlog_assign_tail_lsn() then? > Or are we just being conservative in case we missed something? Conservative - the last thing I want is to introduce a subtle difference to the tail lsn in the log record because we didn't update it immediately before writing it to disk. I think we are probably safe removing it, but lets leave that until we got some wider test coverage on this change first.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct list_head, Josef 'Jeff' Sipek |
|---|---|
| Next by Date: | Re: kernel oops on debian, 2.6.18-5, large xfs volume, David Chinner |
| Previous by Thread: | Re: [patch] Prevent AIL lock contention during transaction completion, Timothy Shimmin |
| Next by Thread: | [patch] Use atomics for iclog reference counting, David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |