xfs
[Top] [All Lists]

Re: Important regression with XFS update for 2.6.24-rc6

To: David Chinner <dgc@xxxxxxx>
Subject: Re: Important regression with XFS update for 2.6.24-rc6
From: Damien Wyart <damien.wyart@xxxxxxx>
Date: Wed, 19 Dec 2007 12:17:30 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Lachlan McIlroy <lachlan@xxxxxxx>, Peter Leckie <pleckie@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20071219104544.GC4612@xxxxxxx> (David Chinner's message of "Wed, 19 Dec 2007 21:45:44 +1100")
References: <20071218112804.GA3069@xxxxxxxxxxxxxxxxxxxxx> <20071218122445.GJ4396912@xxxxxxx> <877ijckrco.fsf@xxxxxxx> <20071218151946.GQ4396912@xxxxxxx> <20071219104544.GC4612@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50
* David Chinner <dgc@xxxxxxx> [071219 11:45]:
> Can someone pass me a brown paper bag, please?

My first impression on this bug was not so wrong, after all ;-)

> That also explains why we haven't seen it - it requires the user
> buffer to fill on the first entry of a backing buffer and so it is
> largely dependent on the pattern of name lengths, page size and
> filesystem block size aligning just right to trigger the problem.

I guess I was lucky to trigger it quite easily...

> Can you test this patch, Damien?

Works fine, all the bad symptoms have disappeared and strace output is
normal.

So you can add:

Tested-by: Damien Wyart <damien.wyart@xxxxxxx>

-- 
Damien


<Prev in Thread] Current Thread [Next in Thread>