xfs
[Top] [All Lists]

Re: xfs mknod regression

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: Re: xfs mknod regression
From: "Bret Towe" <magnade@xxxxxxxxx>
Date: Tue, 18 Dec 2007 18:46:30 -0800
Cc: linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=oljgLXD15oy16UYG67gWJBEDHI4kZx0QPzQFGK7LhDc=; b=oXallLNn78eRzjPrgGzJ+w6iF8OcRoYxL3NONMM4cMJjAFo67N05SJcgtOdmCdWIEjdz2XR/vBy3WG6c8nGHeoPS3y7ntYllZnxs7my4oAGV/T6XMusCwkq9idjPm7VhbMKm0VEW9ZTi3SdBrAlvpvruUFnlCXTC9xKLTXPLzH0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=YKoJiL3tGrtMoEEHz2H/qUiNcSCn1QcHab1X1KD3y1VktA/3PP4eH+y3xU1STODuZqHmWV65uPDVv53Z1WA/1p8QkuznSufuEXRGIuELC0Jbu+XpraQwKwwgISrY+lVRdp8TJEtSEBf0tmmUETyMhmt4ax1bbUhgFMmC/Frg2Os=
In-reply-to: <20071218173642.GA7338@xxxxxxxxxxxxx>
References: <dda83e780712172048n4d40cfcbw4a4d3106fc99f02e@xxxxxxxxxxxxxx> <20071218173642.GA7338@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
On Dec 18, 2007 9:36 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> This was broken by my '[XFS] simplify xfs_create/mknod/symlink prototype',
> which assigned the re-shuffled ondisk dev_t back to the rdev variable in
> xfs_vn_mknod.  Because of that i_rdev is set to the ondisk dev_t instead
> of the linux dev_t later down the function.
>
> Fortunately the fix for it is trivial:  we can just remove the
> assignment because xfs_revalidate_inode has done the proper job before
> unlocking the inode.
>
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

tested the patch on 2 machines and works fine for me

Thanks


<Prev in Thread] Current Thread [Next in Thread>