xfs
[Top] [All Lists]

[PATCH] remove superflous xfs_readsb call in xfs_mountfs

To: xfs@xxxxxxxxxxx
Subject: [PATCH] remove superflous xfs_readsb call in xfs_mountfs
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 18 Dec 2007 18:48:29 +0100
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
When xfs_mountfs is called by xfs_mount xfs_readsb was called 35 lines
above unconditionally, so there is no need to try to read the superblock
if it's not present.  If any other port doesn't have the superblock
read at this point it should just call it directly from it's xfs_mount
equivalent.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c       2007-12-17 14:34:57.000000000 
+0100
+++ linux-2.6-xfs/fs/xfs/xfs_mount.c    2007-12-17 14:35:17.000000000 +0100
@@ -968,11 +968,6 @@ xfs_mountfs(
        int             uuid_mounted = 0;
        int             error = 0;
 
-       if (mp->m_sb_bp == NULL) {
-               error = xfs_readsb(mp, mfsi_flags);
-               if (error)
-                       return error;
-       }
        xfs_mount_common(mp, sbp);
 
        /*


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] remove superflous xfs_readsb call in xfs_mountfs, Christoph Hellwig <=