Re: [PATCH] make xfs_idestroy() wait for log I/O to complete

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Dec 12, 2007 at 06:20:35PM +1100, Lachlan McIlroy wrote:
> An xfs inode can be destroyed before log I/O involving that inode
> is complete.  We need to wait for the inode to be unpinned before
> tearing it down.  The patch looks big but the only real change is
> adding a call to xfs_iunpin_wait() to the start of xfs_idestroy().
> The rest of the patch is moving xfs_idestroy() after the pinning
> routines.

Making sure the inode is unpinned before it's destroyed definitvely
sounds useful.  I can't think of any harm this might cause either.

I'd prefer to have to commits, one to move the function around and one
to add the call to xfs_iunpin_wait, though.