[Top] [All Lists]

Re: [PATCH] xfs: revert to double-buffering readdir

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH] xfs: revert to double-buffering readdir
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 3 Dec 2007 15:09:05 +0000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Chris Wedgwood <cw@xxxxxxxx>, linux-xfs@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <474FBA21.4070201@sgi.com>
References: <20071114070400.GA25708@puku.stupidest.org> <20071125163014.GA17922@infradead.org> <474FBA21.4070201@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Fri, Nov 30, 2007 at 06:22:09PM +1100, Timothy Shimmin wrote:
> Hmmm, don't see the point of "eof" local var now.
> Previously bhv_vop_readdir() returned eof.
> I presume if we don't move the offset (offset == startoffset) then
> we're done and break out?
> So we lost eof when going to the filldir in the getdents code etc...

Yes, it's just copy & paste.  We can trivially kill the variable.

<Prev in Thread] Current Thread [Next in Thread>