Re: [PATCH 9/9] Clean up open coded inode dirty checks

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip)
> +{
> +     return (((ip->i_itemp == NULL) ||
> +             !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) &&
> +             (ip->i_update_core == 0));
> +}

Can we please get rid of this useless STATIC_INLINE junk?  It's really
hurting my eyes.  As does to a lesser extent the verbose style of this
function.  This should be something like:

static inline int xfs_inode_clean(struct xfs_inode *ip)
{
        return (!ip->i_itemp ||
                !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) &&
               !ip->i_update_core;
}