| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] Debug - don't exhaustively check the AIL on every operation |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Fri, 23 Nov 2007 12:24:25 +1100 |
| Cc: | David Chinner <dgc@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx> |
| In-reply-to: | <47462222.9060501@xxxxxxx> |
| References: | <20071122005003.GQ114266761@xxxxxxx> <47462222.9060501@xxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Fri, Nov 23, 2007 at 11:43:14AM +1100, Lachlan McIlroy wrote: > Looks good Dave. > > There's lots of debug code bound by XFS_TRANS_DEBUG - should we be > enabling this in our QA? No, they are more for validation when you are hacking on the transaction code. The current debug code should detect most problems runtime problems, but if you change the way anything in the logging works you'll be wanting to test your changes with that set (e.g. when we do the transaction rollback stuff). Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] Debug - don't exhaustively check the AIL on every operation, Lachlan McIlroy |
|---|---|
| Next by Date: | Re: [PATCH 2/9]: Reduce Log I/O latency, Andi Kleen |
| Previous by Thread: | Re: [PATCH 2/2] Debug - don't exhaustively check the AIL on every operation, Lachlan McIlroy |
| Next by Thread: | Warning: could not send message for past 4 hours, Mail Delivery Subsystem |
| Indexes: | [Date] [Thread] [Top] [All Lists] |