Re: [PATCH,RFC] Factor some btree code....

[David Chinner <dgc@xxxxxxx>]

On Wed, Nov 21, 2007 at 03:20:06PM +0000, Christoph Hellwig wrote:
> 
> I like this.  But I think a single set of xfs_btree_ops would be a lot
> more readable.  Also I'm not sure we actually need all these ops, e.g.
> instead of .buf_to_block we could always just call XFS_BUF_PTR directly.

I've already converted it to a single ops structure and cut out quite
a few ops that could be generic (sibling ops, checking ops, numrecs
ops, etc). I opted for moving them all over initially and now I'm culling
the common stuff. .buf_to_block is another one that can go, .buf_to_ptr
can be done generically, too....

I'm still flshing bugs out, so i haven't posted an update. When I get
it to pass xfsqa I'll send out an updated patchset.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group