Re: [PATCH] bulkstat fixups

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

+#define XFS_BULKSTAT_UBLEFT(ubleft)    ((ubleft) >= statstruct_size)
+

        I don't think this macro is really helpful.  An inline would
        have been useful if statstruct_size was constant, but this
        way it's much better to just write out the comparism the four
        times it's used.

+       if (!ubcountp || *ubcountp <= 0) {
+               return EINVAL;
+       }

        No need for the braces here.


I also must say I don't like the cond_resched() calls very much.  They
look entirely random to me.  We really should only need cond_resched
when it's absolutely needed, and it deserves a comment why it's needed
then.