xfs
[Top] [All Lists]

Re: [PATCH, RFC] Move AIL pushing into a separate thread

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH, RFC] Move AIL pushing into a separate thread
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 16 Nov 2007 07:23:13 +0000
Cc: Lachlan McIlroy <lachlan@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>
In-reply-to: <20071116004310.GL66820511@xxxxxxx>
References: <20071105050706.GW66820511@xxxxxxx> <473BBDC1.2020107@xxxxxxx> <20071116004310.GL66820511@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i
On Fri, Nov 16, 2007 at 11:43:10AM +1100, David Chinner wrote:
> > >+          /* Too many items we can't do anything with? */
> > >+          if (stuck > 100)
> > 100?  Arbitrary magic number or was there reason for this?
> 
> Arbitrary magic number based on observation. basically, if
> we are skipping too many items because we can't flush them or
> they are already being flushed we back off and given them time
> to complete whatever operation is being done. i.e. remove pressure
> from the AIL while we can't make progress so traversals don't
> slow down further inserts and remov?ls to/from the AIL.

Might be worth adding something like this as a comment.


<Prev in Thread] Current Thread [Next in Thread>