Re: [[PATCH, RESEND]] V2 inodes per default, and move DFL bits to XFS_DFL_SB_VERSION_BITS,

[David Chinner <dgc@xxxxxxx>]

On Mon, Nov 12, 2007 at 02:48:47PM +1100, xaiki@xxxxxxx wrote:
> From: Niv Sardi <xaiki@xxxxxxx>
> 
> Activate XFS_SB_VERSION_NLINKBIT per default, witch will enable V2 INODES.
> refactor bits that we want everytime in XFS_DFL_SB_VERSION_BITS.

Yay! A description ;)

s/witch/which/

> ---
>  xfsprogs/mkfs/xfs_mkfs.h |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/xfsprogs/mkfs/xfs_mkfs.h b/xfsprogs/mkfs/xfs_mkfs.h
> index f19f917..9291e33 100644
> --- a/xfsprogs/mkfs/xfs_mkfs.h
> +++ b/xfsprogs/mkfs/xfs_mkfs.h
> @@ -18,17 +18,19 @@
>  #ifndef __XFS_MKFS_H__
>  #define      __XFS_MKFS_H__
>  
> +#define XFS_DFL_SB_VERSION_BITS 
> XFS_SB_VERSION_NLINKBIT|XFS_SB_VERSION_EXTFLGBIT
> +

I suggest splitting this over multiple lines and calling it
XFS_DEFAULT_SB_VERSION_BITS.

#define XFS_DEFAULT_SB_VERSION_BITS \
                (XFS_SB_VERSION_NLINKBIT | \
                 XFS_SB_VERSION_EXTFLGBIT)

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group