xfs
[Top] [All Lists]

Re: [xfs-masters] [PATCH] fs/xfs: remove duplicated defines

To: xfs-masters@xxxxxxxxxxx
Subject: Re: [xfs-masters] [PATCH] fs/xfs: remove duplicated defines
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 11 Nov 2007 17:57:35 -0600
Cc: xfs@xxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20071111134351.106efb98@xxxxxxxxxxxxxxx>
References: <20071111134351.106efb98@xxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
Nicolas Kaiser wrote:
> Remove duplicated defines.
> 
> Signed-off-by: Nicolas Kaiser <nikai@xxxxxxxxx>
> ---

Heh, each defined twice, but used 0 times in the kernel.  Could probably
just remove them altogether (though I guess btoc is used in
xfstests/ltp/doio.c in userspace/xfstests, but that's the *only* place)

-Eric

>  fs/xfs/linux-2.6/xfs_linux.h |    4 ----
>  1 file changed, 4 deletions(-)
> 
> --- a/fs/xfs/linux-2.6/xfs_linux.h    2007-11-07 11:26:20.000000000 +0100
> +++ b/fs/xfs/linux-2.6/xfs_linux.h    2007-11-11 13:07:11.000000000 +0100
> @@ -167,12 +167,8 @@
>  
>  /* clicks to bytes */
>  #define      ctob(x)         ((__psunsigned_t)(x)<<BPCSHIFT)
> -#define btoct(x)        ((__psunsigned_t)(x)>>BPCSHIFT)
>  #define      ctob64(x)       ((__uint64_t)(x)<<BPCSHIFT)
>  
> -/* bytes to clicks */
> -#define btoc(x)         (((__psunsigned_t)(x)+(NBPC-1))>>BPCSHIFT)
> -
>  #define ENOATTR              ENODATA         /* Attribute not found */
>  #define EWRONGFS     EINVAL          /* Mount with wrong filesystem type */
>  #define EFSCORRUPTED EUCLEAN         /* Filesystem is corrupted */
> 
> 


<Prev in Thread] Current Thread [Next in Thread>