xfs
[Top] [All Lists]

Re: TAKE 972756 - Implement fallocate.

To: nscott@xxxxxxxxxx
Subject: Re: TAKE 972756 - Implement fallocate.
From: "Bhagi rathi" <jahnu77@xxxxxxxxx>
Date: Wed, 7 Nov 2007 11:12:28 +0530
Cc: "David Chinner" <dgc@xxxxxxx>, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=wlZWvUDl1yZ4aFk5SmE5QW4tW1UDfVwiNd9J8RN7mTk=; b=eIjCB0Sv9TOiztUUbEL+PLfvTO7vL0rx+zc4sVLea302OlHwV8CA6WZS1onJf84Ir9crzPfMxA5MT0IZ4RYRRsr0zSCRyEsE9Uar+1woLJhbvPp/M3mZrWdd3rr7BgelMclrBcFVqasYjQsQj3BhMzsSKKvhDzCWoH+7udMt0Y4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=Fz0P8MWta04jnXP4EppGxDEBGmidyZt3FHCEfzJb91Q8aKHRMlwFqcmwOBWJi4X9q+TQh4nK80ylYBqJZ0ppCuErlfveYeDeaT2V4qXYJm+YZBiNxb0HgmOwwXx/IN8QTVBAuTdZ+NZtq7hw42Dn/k7TobcaPl3r/m0xhWQDeok=
In-reply-to: <1194388733.3862.206.camel@xxxxxxxxxxxxxx>
References: <20071102024314.9BF3458C38F7@xxxxxxxxxxxxxxxxxxxxxxx> <cc7060690711051042h5c39c540mf60f95e2f67c7bd7@xxxxxxxxxxxxxx> <20071106001223.GY66820511@xxxxxxx> <cc7060690711060927n1ea8a489n9f02029a11b73b00@xxxxxxxxxxxxxx> <20071106204100.GW995458@xxxxxxx> <1194388733.3862.206.camel@xxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
Since size log change and data I/O are not binded, it is always possible
that size can reach to the
disk before I/O reaching to the disk. Also, the other problem is because of
speculative allocation.
A write-back allocation can leady to allocation of delayed extents into real
and gets pruned only
close of the file. Before that, we get fallocate, it allocates the exents,
but the extents residing
because of delayed allocation write-back will not have zero'ed content.

Conceptually, fallocate if it intends to change size, it is no way different
from size extending write.
 We do xfs_zero_eof for write and not  in this case. Probably, I am missing
the context of usage of
 fallocate if it has some semantics over-loaded.

-Thanks,
  Bhagi.

On 11/7/07, Nathan Scott <nscott@xxxxxxxxxx> wrote:
>
> On Wed, 2007-11-07 at 07:41 +1100, David Chinner wrote:
> > >  Preallocation happened from 1k to 256k. Now, it looks to me that we
> > have
> > > un-written extents from 4k to 256k. There is no guarantee that data
> > from 1k
> > > to 4k is all zero'es.
>
> That guarantee does exist - when the initial 1K block write is done, the
> end of the block is zeroed (by the kernel write path).  This is always
> done (guaranteed) and is required independently to unwritten extents.
>
> cheers.
>
> --
> Nathan
>
>


[[HTML alternate version deleted]]


<Prev in Thread] Current Thread [Next in Thread>