xfs
[Top] [All Lists]

Re: writeout stalls in current -git

To: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>
Subject: Re: writeout stalls in current -git
From: David Chinner <dgc@xxxxxxx>
Date: Mon, 5 Nov 2007 12:45:10 +1100
Cc: David Chinner <dgc@xxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Fengguang Wu <wfg@xxxxxxxxxxxxxxxx>, Maxim Levitsky <maximlevitsky@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <64bb37e0711040319l5de285c3xea64474540a51b6e@xxxxxxxxxxxxxx>
References: <393060478.03650@xxxxxxxxxxx> <64bb37e0710310822r5ca6b793p8fd97db2f72a8655@xxxxxxxxxxxxxx> <393903856.06449@xxxxxxxxxxx> <64bb37e0711011120i63cdfe3ci18995d57b6649a8@xxxxxxxxxxxxxx> <64bb37e0711011200n228e708eg255640388f83da22@xxxxxxxxxxxxxx> <E1InmAI-0003ME-2i@localhost> <1193998532.27652.343.camel@twins> <64bb37e0711021222q7d12c825mc62d433c4fe19e8@xxxxxxxxxxxxxx> <20071102204258.GR995458@xxxxxxx> <64bb37e0711040319l5de285c3xea64474540a51b6e@xxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Sun, Nov 04, 2007 at 12:19:19PM +0100, Torsten Kaiser wrote:
> On 11/2/07, David Chinner <dgc@xxxxxxx> wrote:
> > That's stalled waiting on the inode cluster buffer lock. That implies
> > that the inode lcuser is already being written out and the inode has
> > been redirtied during writeout.
> >
> > Does the kernel you are testing have the "flush inodes in ascending
> > inode number order" patches applied? If so, can you remove that
> > patch and see if the problem goes away?
> 
> I can now confirm, that I see this also with the current mainline-git-version
> I used 2.6.24-rc1-git-b4f555081fdd27d13e6ff39d455d5aefae9d2c0c
> plus the fix for the sg changes in ieee1394.

Ok, so it's probably a side effect of the writeback changes.

Attached are two patches (two because one was in a separate patchset as
a standalone change) that should prevent async writeback from blocking
on locked inode cluster buffers. Apply the xfs-factor-inotobp patch first.
Can you see if this fixes the problem?

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


Attachment: xfs-factor-inotobp
Description: Text document

Attachment: xfs-iflush-blocking-fix
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>