| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Turn off XBF_READ_AHEAD in io completion |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 1 Nov 2007 10:00:12 +0000 |
| Cc: | xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <47296FF7.8080607@xxxxxxx> |
| References: | <47296FF7.8080607@xxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.3i |
On Thu, Nov 01, 2007 at 05:19:35PM +1100, Lachlan McIlroy wrote: > Read-ahead of an inode cluster will set XBF_READ_AHEAD in the buffer. > If we don't remove the flag it will still be set when we flush the > buffer back to disk. Not sure if leaving this flag set causes any > serious problems but it does trigger an assert. It might be better if such temporary flags never actually make it to bp->b_flags. Just pass down a flags variable all the way to _xfs_buf_ioapply and keep the flags just for this I/O separate from those that are permanent and in bp->b_flags. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Next by Date: | Re: 2.6TB Storage Size Problem, Emmanuel Florac |
|---|---|
| Next by Thread: | Re: [PATCH] Turn off XBF_READ_AHEAD in io completion, Lachlan McIlroy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |