xfs
[Top] [All Lists]

PARTIAL TAKE 971186 - kill superflous buffer locking (2nd attempt)

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: PARTIAL TAKE 971186 - kill superflous buffer locking (2nd attempt)
From: lachlan@xxxxxxx (Lachlan McIlroy)
Date: Thu, 29 Nov 2007 11:44:29 +1100 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
kill superflous buffer locking (2nd attempt)

There is no need to lock any page in xfs_buf.c because we operate
on our own address_space and all locking is covered by the buffer
semaphore.  If we ever switch back to main blockdeive address_space
as suggested e.g. for fsblock with a similar scheme the locking will
have to be totally revised anyway because the current scheme is
neither correct nor coherent with itself.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Thu Nov 29 11:43:17 AEDT 2007
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-buflock
Inspected by:  hch
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30156a
fs/xfs/xfsidbg.c - 1.341 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfsidbg.c.diff?r1=text&tr1=1.341&r2=text&tr2=1.340&f=h
fs/xfs/linux-2.6/xfs_buf.h - 1.123 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_buf.h.diff?r1=text&tr1=1.123&r2=text&tr2=1.122&f=h
fs/xfs/linux-2.6/xfs_buf.c - 1.250 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_buf.c.diff?r1=text&tr1=1.250&r2=text&tr2=1.249&f=h
        - kill superflous buffer locking (2nd attempt)




<Prev in Thread] Current Thread [Next in Thread>
  • PARTIAL TAKE 971186 - kill superflous buffer locking (2nd attempt), Lachlan McIlroy <=