Implementing casefold-table checking in xfs_repair, I have to touch process_dinode_int. It's a horrendous function. The attached patch hopefully makes it much clearer what it does and removes a lot of duplicate code when bad inodes are found. There are some obscure bug fixes too (eg. two places where the inode's di_mode is updated, but not marked dirty - libxfs would have tossed it). The refactoring involved removing unused variables, working out what various variables actually did and use them appropriately and break blocks of functionality into separate functions. Barry.
|
