xfs
[Top] [All Lists]

Re: TAKE 972756 - Implement fallocate.

To: "David Chinner" <dgc@xxxxxxx>
Subject: Re: TAKE 972756 - Implement fallocate.
From: "Bhagi rathi" <jahnu77@xxxxxxxxx>
Date: Tue, 6 Nov 2007 00:12:52 +0530
Cc: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=ullirRnf7fsRwZBlH1YzvyFmG4YErAL/OUOqVi6uLS8=; b=IvQ36/C4C6tAVQ2rKuKSRGhgY93wMsz+WeKAR5lk4vtZc683+c/CVz4PTyYNHGteVzJTEMDSFmDELi+NSDmbliSJZUbgBriag9f40qUUB46i7EWhgLPtmlftSv+e2k+nWnUtfiL0iFWCmk0QCPZOcr36EfX7yHYT2BO1rqUw7ug=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=qogWKHDaP0qAOLEfPvv/Rb+hXm/gur0LikbahJvvscOwTK+pJQiKjuJpikQ9d+oLGMiBaY7wncddsBV3OOhmSVvNN3qpenqZ7Tk+k40+cv0TjIpZtfSx5RLJ6iVsOztlivtyH9VFpclbxqAq5pNjA6JUckc/1owbi+Q7eNEhZ7U=
In-reply-to: <20071102024314.9BF3458C38F7@chook.melbourne.sgi.com>
References: <20071102024314.9BF3458C38F7@chook.melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
David, What happens if offset is not aligned to 4k? Let's say we have a file
whose size is
not aligned to 4k. It could have blocks beyond the eof which haven't been
zero'ed out.
fallocate may increase the size and we can read garbage from disk-block if
it hasn't
been zero'ed out.

-Thanks,
 Bhagi.

On 11/2/07, David Chinner <dgc@xxxxxxx> wrote:
>
> Implement fallocate.
>
> Implement the new generic callout for file preallocation.
> Atomically change the file size if requested.
>
>
> Date:  Fri Nov  2 13:42:52 AEDT 2007
> Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
> Inspected by:  hch@xxxxxxxxxxxxx
>
> The following file(s) were checked into:
>   longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
>
>
> Modid:  xfs-linux-melb:xfs-kern:30009a
> fs/xfs/linux-2.6/xfs_iops.c - 1.268 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/> 
linux-2.6/xfs_iops.c.diff?r1=text&tr1=1.268&r2=text&tr2=1.267&f=h
>
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_iops.c.diff?r1=text&tr1=1.268&r2=text&tr2=1.267&f=h
>         - implement ->fallocate()
>
>
>
>


[[HTML alternate version deleted]]


<Prev in Thread] Current Thread [Next in Thread>