xfs
[Top] [All Lists]

Re: Review: Make xfs_bulkstat() to report unlinked but referenced inodes

To: xfs-dev <xfs-dev@xxxxxxx>
Subject: Re: Review: Make xfs_bulkstat() to report unlinked but referenced inodes
From: Vlad Apostolov <vapo@xxxxxxx>
Date: Fri, 19 Oct 2007 10:51:29 +1000
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4715A22D.1070409@xxxxxxx>
References: <4715A22D.1070409@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.6 (X11/20070728)
ping!

I ran XFS QA with this patch and didn't see any regressions and
I (and Judith in US) have verified the expected behavior - xfs_bulkstat()
now reports referenced inodes with link count of zero.

Regards,
Vlad

Vlad Apostolov wrote:
We need xfs_bulkstat() to report inode stat for inodes with
link count zero but reference count non zero.

The fix here:

http://oss.sgi.com/archives/xfs/2007-09/msg00266.html

changed this behavior and made xfs_bulkstat() to filter all
unlinked inodes including those that are not destroyed yet but
held by reference.

The attached patch returns back to the original behavior by
marking the on-disk inode buffer "dirty" when di_mode is cleared
(at that time both inode link and reference counter are zero).

Regards,
Vlad


<Prev in Thread] Current Thread [Next in Thread>