| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: Review: Fix dbflush panic in xfs_qm_sync |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Tue, 16 Oct 2007 16:07:26 +1000 |
| Cc: | Donald Douwsma <donaldd@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4714498A.8090902@xxxxxxx> |
| References: | <4713F7D3.2090201@xxxxxxx> <4714498A.8090902@xxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Tue, Oct 16, 2007 at 03:18:02PM +1000, Lachlan McIlroy wrote: > Could mp->m_quotainfo become NULL after this check but before we > lock the list with xfs_qm_mplist_lock()? There doesn't seem to > be any locking to protect changes to this field? Possible - in theory. Likely - no. We do the same unlocked check in a few places... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: Fix dbflush panic in xfs_qm_sync, Lachlan McIlroy |
|---|---|
| Next by Date: | (no subject), Niv Sardi-Altivanik |
| Previous by Thread: | Re: Review: Fix dbflush panic in xfs_qm_sync, Lachlan McIlroy |
| Next by Thread: | Re: Review: Fix dbflush panic in xfs_qm_sync, Donald Douwsma |
| Indexes: | [Date] [Thread] [Top] [All Lists] |