| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: review: use correct buffer flags when reading superblock |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Wed, 10 Oct 2007 21:28:21 +1000 |
| Cc: | xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <470C8F5B.90705@xxxxxxx> |
| References: | <470C8F5B.90705@xxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Wed, Oct 10, 2007 at 06:37:47PM +1000, Lachlan McIlroy wrote: > When reading the superblock during log recovery we are not setting > the correct buffer flags. Specifically we are not turning off flags > we do not need such as XBF_ASYNC that is causing the synchronous > xfs_iowait() to hang. We should also turn off XBF_WRITE and remove > the buffer from the delay write queue just to be safe. We really don't need the removal of the write flags - the XFS_bflush() call above the xfs_getsb() call guarantees that they won't be set.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: review: use correct buffer flags when reading superblock, David Chinner |
|---|---|
| Next by Date: | running xfs_repair on large partitions, Louis-David Mitterrand |
| Previous by Thread: | Re: review: use correct buffer flags when reading superblock, David Chinner |
| Next by Thread: | Re: review: use correct buffer flags when reading superblock, Lachlan McIlroy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |