Re: [PATCH V2] Ensure sync flushes all dirty data to disk]

[David Chinner <dgc@xxxxxxx>]

On Tue, Oct 09, 2007 at 05:34:04PM +1000, Lachlan McIlroy wrote:
> [V2 adds a comment for dgc]
> 
> In xfs_fs_sync_super() treat a sync the same as a filesystem freeze.
> This is needed to force the log to disk for inodes which are not marked
> dirty in the Linux inode (the inodes are marked dirty on completion of
> the log I/O) and so sync_inodes() will not flush them.
> 
> In xfs_fs_write_inode() a synchronous flush will not get an EAGAIN
> from xfs_inode_flush() and if an asynchronous flush returns EAGAIN
> we should pass it on to the caller.  If we get an error while flushing
> the inode then re-dirty it so we can try again later.

Looks good now, Lachlan.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group