xfs
[Top] [All Lists]

PARTIAL TAKE 971186 - kill superflous buffer locking

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: PARTIAL TAKE 971186 - kill superflous buffer locking
From: lachlan@xxxxxxx (Lachlan McIlroy)
Date: Mon, 8 Oct 2007 16:15:54 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
kill superflous buffer locking

There is no need to lock any page in xfs_buf.c because we operate
on our own address_space and all locking is covered by the buffer
semaphore.  If we ever switch back to main blockdeive address_space
as suggested e.g. for fsblock with a similar scheme the locking will
have to be totally revised anyway because the current scheme is
neither correct nor coherent with itself.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Mon Oct  8 16:14:29 AEST 2007
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-oss
Inspected by:  Christoph Hellwig <hch@xxxxxx>
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:29845a
fs/xfs/xfsidbg.c - 1.339 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfsidbg.c.diff?r1=text&tr1=1.339&r2=text&tr2=1.338&f=h
fs/xfs/linux-2.6/xfs_buf.h - 1.121 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_buf.h.diff?r1=text&tr1=1.121&r2=text&tr2=1.120&f=h
fs/xfs/linux-2.6/xfs_buf.c - 1.245 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_buf.c.diff?r1=text&tr1=1.245&r2=text&tr2=1.244&f=h
        - kill superflous buffer locking




<Prev in Thread] Current Thread [Next in Thread>
  • PARTIAL TAKE 971186 - kill superflous buffer locking, Lachlan McIlroy <=