>
> This time against CVS
>
> Replace XFS bit functions with call Linux functions
>
> XFS had some own functions to find high and low bits.
>
> This patch replaces them with a call to the respective Linux functions.
> The semantics of the Linux functions differ a little, but i checked
> all call sites that they can deal with that.
Several of these call sites are also compiled in userspace in libxfs. It
would
be a good idea from that POV also to keep some level of abstraction so that
these calls can be mapped to userspace routines as well.
> The resulting xfs.ko is about 500 bytes smaller on x86-64
Thats it? To be honest, this sounds like just code churn and risk
introduction.
What testing was done? Changes to some of these routines has introuced
subtle log recovery bugs in the past - has recovery been tested at all?
The QA
suite has some log recovery tests, it'd be a good idea to verify with those..
cheers.
--
Nathan
|