xfs
[Top] [All Lists]

Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 29 Sep 2007 10:45:52 +0100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20070919161202.GA18130@xxxxxx>
References: <20070919161202.GA18130@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i
On Wed, Sep 19, 2007 at 06:12:03PM +0200, Christoph Hellwig wrote:
> This macro is unused an all other acros in this family operate on native
> types, so we most likely won't grow a user either.

Could anyone put this trivial remove one line patch in?

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: linux-2.6.23-rc6/fs/xfs/xfs_ialloc_btree.h
> ===================================================================
> --- linux-2.6.23-rc6.orig/fs/xfs/xfs_ialloc_btree.h   2007-09-18 
> 16:27:08.000000000 +0200
> +++ linux-2.6.23-rc6/fs/xfs/xfs_ialloc_btree.h        2007-09-18 
> 16:27:18.000000000 +0200
> @@ -81,8 +81,6 @@ typedef     struct xfs_btree_sblock xfs_inob
>  #define      XFS_INOBT_MASK(i)               ((xfs_inofree_t)1 << (i))
>  #define      XFS_INOBT_IS_FREE(rp,i)         \
>               (((rp)->ir_free & XFS_INOBT_MASK(i)) != 0)
> -#define      XFS_INOBT_IS_FREE_DISK(rp,i)    \
> -             ((be64_to_cpu((rp)->ir_free) & XFS_INOBT_MASK(i)) != 0)
>  #define      XFS_INOBT_SET_FREE(rp,i)        ((rp)->ir_free |= 
> XFS_INOBT_MASK(i))
>  #define      XFS_INOBT_CLR_FREE(rp,i)        ((rp)->ir_free &= 
> ~XFS_INOBT_MASK(i))
>  
> 
> 
---end quoted text---


<Prev in Thread] Current Thread [Next in Thread>