| To: | Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsidbg: kill vnode leftovers |
| From: | Donald Douwsma <donaldd@xxxxxxx> |
| Date: | Tue, 25 Sep 2007 15:53:11 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20070924180732.GA17635@xxxxxx> |
| References: | <20070924180732.GA17635@xxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.6 (Macintosh/20070728) |
Christoph Hellwig wrote: While we're at fixing up xfsidbg I have this little gem: Kill the kdbm_vn, kdbm_vnode and xi2vnode xfsidbg commands. The last one just printed a Linux inode (despite it's description) and that is much better done by the inode command in kdb/modules/kdbm_pg.c. The latter two both print the vnode (nothing left here) and the inode and again that is better done using the inode command. Interestingly those latter two did exactly the same despite their quite different descriptions which weren't correct for either command. Thanks Christoph, its good to remove the cruft. 78 commands in there at the moment. Any we can get rid of make it easier to use. Don |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: something very strange w/ filestreams..., Eric Sandeen |
|---|---|
| Next by Date: | PARTIAL TAKE 970982 - Misc xfsidbg updates., donaldd |
| Previous by Thread: | [PATCH] xfsidbg: kill vnode leftovers, Christoph Hellwig |
| Next by Thread: | [PATCH] kill superflous buffer locking, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |