Re: [PATCH 5/4] simplify xfs_create/mknod/symlink prototype

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Eric Sandeen wrote:
> Christoph Hellwig wrote:
>> (sorry, go the patch numbering one off)
>>
>> Simplify the prototype for xfs_create/xfs_mkdir/xfs_symlink by not
>> passing down a bhv_vattr_t that just hogs stack space.  Instead pass
>> down the mode in a mode_t and in case of xfs_crate the rdev as a scalar
>> type aswell.
> 
> With this whole patch series, I see these stack reductions on my x86
> box, nice!
> 

> -xfs_symlink [xfs]: 240
> +xfs_symlink [xfs]: 256

Although, that one is a little unfortunate ;)

-eric