xfs
[Top] [All Lists]

Re: [PATCH 5/4] simplify xfs_create/mknod/symlink prototype

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 5/4] simplify xfs_create/mknod/symlink prototype
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 14 Sep 2007 13:34:26 -0500
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <46EAD364.7060305@xxxxxxxxxxx>
References: <20070914163041.GG7110@xxxxxx> <46EAD364.7060305@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.12 (X11/20070530)
Eric Sandeen wrote:
> Christoph Hellwig wrote:
>> (sorry, go the patch numbering one off)
>>
>> Simplify the prototype for xfs_create/xfs_mkdir/xfs_symlink by not
>> passing down a bhv_vattr_t that just hogs stack space.  Instead pass
>> down the mode in a mode_t and in case of xfs_crate the rdev as a scalar
>> type aswell.
> 
> With this whole patch series, I see these stack reductions on my x86
> box, nice!
> 

> -xfs_symlink [xfs]: 240
> +xfs_symlink [xfs]: 256

Although, that one is a little unfortunate ;)

-eric


<Prev in Thread] Current Thread [Next in Thread>