[Top] [All Lists]

Re: [xfs-masters] [Bug 768] New: Move restrict_chown to mount-time opti

To: Josef Sipek <jsipek@xxxxxxxxxxxxxxxxx>
Subject: Re: [xfs-masters] [Bug 768] New: Move restrict_chown to mount-time option
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 7 Sep 2007 21:04:27 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, nick.couchman@xxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20070906161006.GA25035@xxxxxxxxxxxxxxxxxxxxxxx>
References: <200709051831.l85IVsTR016106@xxxxxxxxxxx> <20070906153529.GA3062@xxxxxx> <20070906161006.GA25035@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Thu, Sep 06, 2007 at 12:10:06PM -0400, Josef Sipek wrote:
> > It's quite easily doable.  I don't have time for that right now, but if
> > anyone wants to do it's just adding the option to the mount option
> > parser and adding a flag to the mount structure.
> Wouldn't making this a generic mount-option make sense? Or is it far too
> low-level of a concept?

Basically it's a simple boolean flag that's checked in the inode
allocator when we decide about the permission of the newly created
inode.  Because of that the implementation will be inherently
filesystem-specific.  We could still add a binary mount flag for it in
common code, but my stance is to only add these when we actually need
to check the flag in general code.

<Prev in Thread] Current Thread [Next in Thread>