Re: TAKE 970240 - kill BMAPI_DEVICE

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Fri, Sep 14, 2007 at 12:53:20AM +0530, Bhagi rathi wrote:
> Can one of you let me know the process of submitting changes?

Just send a unified diff (using diff -u) to the list.

> 
> Problem: Real time flag set on a regular file can race with directio which
> can lead to
>               incorrect real time device for iomap in xfs_vm_direct_IO. This
> can happen
>               only on the first I/O to the file as we don't set real time
> flag if any of
>               the extents or delayed blocks present.
> 
> Fix:
> 
>   xfs_setattr() {
>           ...
>           if (!(mask & XFS_AT_SIZE)) {
>                  if (need_io_lock && vap->va_xflags & XFS_XFLAG_REALTIME)
>                         lock_flags |= XFS_IOLOCK_EXCL;
>                  .....
>           }

I have a patch queued up aswell, although it's after a reorganization of
the code to not clutter xfs_setattr even more.  If you want to send out
the fix now please go ahead.